Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Main -> Latest #233

Merged
merged 6 commits into from
Nov 22, 2024
Merged

Main -> Latest #233

merged 6 commits into from
Nov 22, 2024

Conversation

KonnorRogers
Copy link
Owner

No description provided.

KonnorRogers and others added 6 commits November 22, 2024 16:50
* fix upload success events

* remove console.log

* prettier

* prettier

* add changelog entry
* Focus the editor when link dialog is closed.

This is especially useful when the ESC key is hit. Without this, the
link dialog disappears, you expect to be able to continue editing, but
the editor does not have focus. Now it does!

* Update addLink behavior to handle editing link without a full selection.

When your cursor is within a node of linked text and the link dialog is
opened, the intention is almost always to edit the link for the full
node rather than insert a new link in place of the text for which the
cursor is sitting.

Here's how this interaction worked before:

https://share.cleanshot.com/1NYHrBxP

With this change, editing a link when the cursor is within a linked
node will edit the link for the entire linked text rather than replacing
or inserting the new link in place of or in the midst of the linked
node text.

Here is the change in action:

https://share.cleanshot.com/gLjDmjwN

* Show invalid URL message when link validity is broken.

Prior to this the text field would turn red, but the "Not a valid URL"
message did not appear to the user.

* Create violet-queens-perform.md

---------

Co-authored-by: Konnor Rogers <konnor5456@gmail.com>
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Copy link

vercel bot commented Nov 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
rhino-editor ✅ Ready (Inspect) Visit Preview Nov 22, 2024 10:06pm

Copy link

changeset-bot bot commented Nov 22, 2024

⚠️ No Changeset found

Latest commit: 8d0cc73

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@KonnorRogers KonnorRogers merged commit 0c7901c into latest Nov 22, 2024
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants